Not surprised. Did the graph look like the one shone here in The Problem? https://mtyurt.net/post/git-using-advanced-rebase-features-for-a-clean-repository.html
― Isolde mein Herz zum Junker (James Redd and the Blecchs), Tuesday, 14 July 2020 18:36 (three years ago) link
Can you lock out all merges? We have fast-forward-only some branches but then I recently noticed that some of the more unenlightened just merge that branch into theirs and then they can fast-forward this merged melange back.
― Isolde mein Herz zum Junker (James Redd and the Blecchs), Tuesday, 14 July 2020 18:38 (three years ago) link
I missed out on the TDD conversation but I wanted to mention that my one experience pairing with a TDD disciple involved watching her create a bunch of tests that were logically incorrect, getting them to pass, and missing giant pieces of logic that interconnected subsystems of the module we were working on and actively mocking other pieces of functionality we were supposed to be testing, so technically we wrote passing code according to the tests but, because the tests weren't actually right, the whole thing was super buggy and caused a bunch of later rework.
I know this isn't the fault of TDD per se but it did play into a lot of my preconceived notions against it.
Re: merge commits, I don't see why anyone should care what I do on my feature branch as long as I squash-merge into the main branch.
― shout-out to his family (DJP), Tuesday, 14 July 2020 18:49 (three years ago) link
Yeah we don’t care what you do on feature branches but main (nee master) is ff only enforced via our code review thing (gerrit). What this means in practice is you hit “merge” and gerrit rebased your change into the tip of main then merged by ff. if there’s a conflict you have to resolve it and resubmit the review. We used to let people do that without running the tests but the number of people who committed the string “>>>>>>>>>” was getting out of hand so it has to at least build after a manually resolved merge conflict.
― 𝔠𝔞𝔢𝔨 (caek), Tuesday, 14 July 2020 18:55 (three years ago) link
Doowatchyalike, just don't create a twelve-lane merge superhighway and then (DEAD) BEEF when your merges ultimately break down.
― Isolde mein Herz zum Junker (James Redd and the Blecchs), Wednesday, 15 July 2020 13:55 (three years ago) link
https://www.destroyallsoftware.com/blog/2017/the-biggest-and-weirdest-commits-in-linux-kernel-git-history
― all cats are beautiful (silby), Wednesday, 15 July 2020 15:17 (three years ago) link
Thanks.Also, I misspelled Doowutchyalike.
― Isolde mein Herz zum Junker (James Redd and the Blecchs), Wednesday, 15 July 2020 17:49 (three years ago) link
It's pulled, and it's fine, but there's clearly a balance between "octopus merges are fine" and "Christ, that's not an octopus, that's a Cthulhu merge".
― brimstead, Wednesday, 15 July 2020 18:20 (three years ago) link
I would just like to take a moment to say javascript sucks and lodash sucks and _.times REALLY sucks
Why does every fucking thing have to be a function, how about you () => juggle(myBalls)
― shout-out to his family (DJP), Wednesday, 15 July 2020 18:48 (three years ago) link
Not only does it all have to be a function but there’s a strong convention that functions be anonymous whenever possible because fuck the reader, right?
― 𝔠𝔞𝔢𝔨 (caek), Wednesday, 15 July 2020 19:10 (three years ago) link
Isn’t most of lodash in es whatever these days though?
― 𝔠𝔞𝔢𝔨 (caek), Wednesday, 15 July 2020 19:11 (three years ago) link
our linting rules haven't been updated yet to favor the native implementations, why because fuck everything and everyone
― shout-out to his family (DJP), Wednesday, 15 July 2020 19:12 (three years ago) link
imo this is what happens when you let Perl aficionados design everything
― shout-out to his family (DJP), Wednesday, 15 July 2020 19:13 (three years ago) link
Don't worry, Dan, it will be updated just as soon as Perl6 is production.
― Isolde mein Herz zum Junker (James Redd and the Blecchs), Wednesday, 15 July 2020 19:23 (three years ago) link
juggle(this.nuts)
― cherry blossom, Wednesday, 15 July 2020 19:26 (three years ago) link
everything being a function is good not bad tbh
― all cats are beautiful (silby), Wednesday, 15 July 2020 21:17 (three years ago) link
fuck state, keep it in a box
counterpoint: nah
― shout-out to his family (DJP), Wednesday, 15 July 2020 23:20 (three years ago) link
Mutable state is a turd on the polished marble floor of my exquisite grand hall hung with crystal chandeliers
― all cats are beautiful (silby), Wednesday, 15 July 2020 23:27 (three years ago) link
https://www.youtube.com/watch?v=Xwm3eW9YyFw
― Isolde mein Herz zum Junker (James Redd and the Blecchs), Wednesday, 15 July 2020 23:33 (three years ago) link
Classic or dud: late night email from colleague cc-ing management saying he can’t figure out something you gave him a few weeks ago and it is crashing and you need to put in more error checking etc. ( because his time and productivity etc)
― Isolde mein Herz zum Junker (James Redd and the Blecchs), Thursday, 16 July 2020 18:40 (three years ago) link
Well this has been sorted for now.
― Left Eye Frizzell (James Redd and the Blecchs), Sunday, 19 July 2020 13:17 (three years ago) link
# get password via terminal without echoingpassword = STDIN.noecho(&:gets).chomp
reasonable, right? sentence in english explaining the cryptic command that follows. i don't get the "document WHY not WHAT" review comments i always get.
coming new to this code, debugging it later say, such things let you understand which part does what without having to decode the code. = useful, especially if you're in a mixed ability team.
also, review comments from people you haven't asked for reviews, classic or dud?
― koogs, Tuesday, 21 July 2020 13:09 (three years ago) link
Leaning towards dud.
― Left Eye Frizzell (James Redd and the Blecchs), Tuesday, 21 July 2020 13:15 (three years ago) link
Codesplainers gonna codesplain.
― Left Eye Frizzell (James Redd and the Blecchs), Tuesday, 21 July 2020 13:17 (three years ago) link
If people would just put in fucking comments saying what they were trying to do and what their expectations were, basically defining the contract they're trying to fulfill, it would be about 8 billion times easier to identify logic mistakes than it currently is.
― shout-out to his family (DJP), Tuesday, 21 July 2020 13:31 (three years ago) link
https://www.hillelwayne.com/post/what-comments/
― 𝔠𝔞𝔢𝔨 (caek), Tuesday, 21 July 2020 13:40 (three years ago) link
i have an issue with that
> //f.ex $F1a3
f.ex? for example? what's wrong with 'ie' or 'eg'?
― koogs, Tuesday, 21 July 2020 13:56 (three years ago) link
(my whole script only exists because someone checked in an aws kms encrypted key without explaining how it was generated, and 3 years later we needed another - lack of documentation again)
― koogs, Tuesday, 21 July 2020 13:58 (three years ago) link
I can see where the anti comment review on that is coming from. The comment duplicates stuff that’s in the docs, right? It’s not a “trick” that depends on undocumented behaviour (like the fact that piping to xargs is a way to trim leading and trailing white space?! Did you all know this?!). It’s just something that’s not obvious from reading the code. That’s not where I draw the line and your point about mixed ability teams is a good one, but it’s not a terrible place to draw it.
― 𝔠𝔞𝔢𝔨 (caek), Tuesday, 21 July 2020 14:04 (three years ago) link
Whoa, xargs trick is neat!
― Left Eye Frizzell (James Redd and the Blecchs), Tuesday, 21 July 2020 14:10 (three years ago) link
I am old. I still use xargs -i and never switched to -I
― Left Eye Frizzell (James Redd and the Blecchs), Tuesday, 21 July 2020 14:13 (three years ago) link
Also can never remember that xargs idiom using the shell trick.
― Left Eye Frizzell (James Redd and the Blecchs), Tuesday, 21 July 2020 14:18 (three years ago) link
Ah, xargs -0 will keep the whitespace
― Left Eye Frizzell (James Redd and the Blecchs), Tuesday, 21 July 2020 14:22 (three years ago) link
Feel like comments should be judged on their practical effects rather than from some philosophical position. If it takes 2 minutes to figure out a chunk of code without comments and 10 seconds to figure out the code with comments, I don't care how "obvious" or "self documenting" the code itself is, the comments are good.
― Dan I., Tuesday, 21 July 2020 14:25 (three years ago) link
otm
― Left Eye Frizzell (James Redd and the Blecchs), Tuesday, 21 July 2020 14:28 (three years ago) link
I say this as person who long ago took a course - in Pascal! - nicknamed "Commenting For Credit" in which people were expected to do things like
i := I + 1; //increment I
― Left Eye Frizzell (James Redd and the Blecchs), Tuesday, 21 July 2020 14:32 (three years ago) link
(input wants to uppercase every i)
i := i + 1; //increment i again
― Left Eye Frizzell (James Redd and the Blecchs), Tuesday, 21 July 2020 14:33 (three years ago) link
Next topic: git commit messages.
//increment topic
― Left Eye Frizzell (James Redd and the Blecchs), Tuesday, 21 July 2020 14:36 (three years ago) link
ruby doesn't let you i++. spent a chunk of sunday looking at cryptic error message and not seeing the problem.
― koogs, Tuesday, 21 July 2020 14:44 (three years ago) link
Can we attach this to everyone's monitor?
― shout-out to his family (DJP), Tuesday, 21 July 2020 14:58 (three years ago) link
I think I only write comments that are at least 100 words long
― all cats are beautiful (silby), Tuesday, 21 July 2020 15:08 (three years ago) link
I'm the only one reading my code/commenting so too many of my comments are targeted at my osteoporosis of a memory, e.g.,
// The + 16 offset is event type, commenting so I don't forget it yet again// The + 16 offset is still event type, it appears I forgot it again
― like, I’m eating an elephant head (katherine), Tuesday, 21 July 2020 15:32 (three years ago) link
(4000 lines apart, to be fair, and not my code but decompiler output)
― like, I’m eating an elephant head (katherine), Tuesday, 21 July 2020 15:33 (three years ago) link
public static final int EVENT_TYPE_OFFSET = 16;
― koogs, Tuesday, 21 July 2020 15:35 (three years ago) link
trust me that's not feasible in this thing, it's certainly possible but this is 240K lines of code and I can't just ctrl-f
― like, I’m eating an elephant head (katherine), Tuesday, 21 July 2020 15:53 (three years ago) link
Btw, my posts from a few weeks ago was about colleagues who are part of the development process and are participating in alpha testing but seem to want to behave as if they are end users and are shocked - shocked! - when something breaks. Perhaps this is a touchy subject.
― Left Eye Frizzell (James Redd and the Blecchs), Tuesday, 21 July 2020 16:21 (three years ago) link
Because no one wants to be that guy that breaks things.
― Left Eye Frizzell (James Redd and the Blecchs), Tuesday, 21 July 2020 16:28 (three years ago) link
But only the other hand there is the short-term/local/pre-mature optimization of being fast on the send button with "It broke! Nothing should ever break!"
― Left Eye Frizzell (James Redd and the Blecchs), Tuesday, 21 July 2020 16:30 (three years ago) link
"Strike mine eyes from my face!"
― Left Eye Frizzell (James Redd and the Blecchs), Tuesday, 21 July 2020 16:31 (three years ago) link